From 4d13ffdc26e2d96279c432171f232a9d46184e66 Mon Sep 17 00:00:00 2001 From: John Guo Date: Mon, 23 May 2022 22:23:29 +0800 Subject: [PATCH] improve ut case for empty upload file validation --- .../ghttp_z_unit_feature_request_file_test.go | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/net/ghttp/ghttp_z_unit_feature_request_file_test.go b/net/ghttp/ghttp_z_unit_feature_request_file_test.go index 44dac9815..ae8babccb 100644 --- a/net/ghttp/ghttp_z_unit_feature_request_file_test.go +++ b/net/ghttp/ghttp_z_unit_feature_request_file_test.go @@ -224,18 +224,9 @@ func Test_Params_File_Upload_Required(t *testing.T) { } type Res struct{} - dstDirPath := gfile.Temp(gtime.TimestampNanoStr()) s := g.Server(guid.S()) + s.Use(ghttp.MiddlewareHandlerResponse) s.BindHandler("/upload/required", func(ctx context.Context, req *Req) (res *Res, err error) { - var ( - r = g.RequestFromCtx(ctx) - ) - - file := req.File - if name, err := file.Save(dstDirPath); err == nil { - r.Response.WriteExit(name) - } - r.Response.WriteExit("upload failed") return }) s.SetDumpRouterMap(false) @@ -246,9 +237,7 @@ func Test_Params_File_Upload_Required(t *testing.T) { gtest.C(t, func(t *gtest.T) { client := g.Client() client.SetPrefix(fmt.Sprintf("http://127.0.0.1:%d", s.GetListenedPort())) - _, err := client.Post(ctx, "/upload/required") - if err != nil { - t.Assert(err.Error(), "upload file is required") - } + content := client.PostContent(ctx, "/upload/required") + t.Assert(content, `{"code":51,"message":"upload file is required","data":null}`) }) }