bingyi/gf
1
0
Fork 0
mirror of https://gitee.com/johng/gf synced 2026-06-06 02:25:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(database/gdb): performance improvement in fields grouping when in… (#4440)

Browse Source 
fix https://github.com/gogf/gf/issues/3906

<img width="2604" height="980" alt="image"
src="https://github.com/user-attachments/assets/50852928-7ff5-4676-8ecf-6960c184e805"
/>

---------

Co-authored-by: hailaz <739476267@qq.com>
This commit is contained in:
613
2025-09-26 11:11:14 +08:00
committed by GitHub
parent d2bc5d812b
commit b60b04e27a
3 changed files with 99 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
database/gdb/gdb_core.go
View File

@ -12,6 +12,7 @@ import (
"database/sql"
"fmt"
"reflect"
"sort"
"strings"
"github.com/gogf/gf/v2/container/gmap"
@ -446,25 +447,30 @@ func (c *Core) DoInsert(ctx context.Context, link Link, table string, list List,
// It here uses ListMap to keep sequence for data inserting.
// ============================================================================================
var keyListMap = gmap.NewListMap()
var tmpkeyListMap = make(map[string]List)
for _, item := range list {
var (
tmpKeys = make([]string, 0)
tmpKeysInSequenceStr string
)
mapLen := len(item)
if mapLen == 0 {
continue
}
tmpKeys := make([]string, 0, mapLen)
for k := range item {
tmpKeys = append(tmpKeys, k)
}
keys, err = c.fieldsToSequence(ctx, table, tmpKeys)
if err != nil {
return nil, err
if mapLen > 1 {
sort.Strings(tmpKeys)
}
tmpKeysInSequenceStr = gstr.Join(keys, ",")
if !keyListMap.Contains(tmpKeysInSequenceStr) {
keyListMap.Set(tmpKeysInSequenceStr, make(List, 0))
keys = tmpKeys // for fieldsToSequence
tmpKeysInSequenceStr := gstr.Join(tmpKeys, ",")
if tmpkeyListMapItem, ok := tmpkeyListMap[tmpKeysInSequenceStr]; ok {
tmpkeyListMap[tmpKeysInSequenceStr] = append(tmpkeyListMapItem, item)
} else {
tmpkeyListMap[tmpKeysInSequenceStr] = List{item}
}
tmpKeysInSequenceList := keyListMap.Get(tmpKeysInSequenceStr).(List)
tmpKeysInSequenceList = append(tmpKeysInSequenceList, item)
keyListMap.Set(tmpKeysInSequenceStr, tmpKeysInSequenceList)
}
for tmpKeysInSequenceStr, itemList := range tmpkeyListMap {
keyListMap.Set(tmpKeysInSequenceStr, itemList)
}
if keyListMap.Size() > 1 {
var (
@ -488,6 +494,15 @@ func (c *Core) DoInsert(ctx context.Context, link Link, table string, list List,
return &sqlResult, err
}
keys, err = c.fieldsToSequence(ctx, table, keys)
if err != nil {
return nil, err
}
if len(keys) == 0 {
return nil, gerror.NewCode(gcode.CodeInvalidParameter, "no valid data fields found in table")
}
// Prepare the batch result pointer.
var (
charL, charR = c.db.GetChars()