From d260de15ba61e589c58d803462cd26f4e7a10ce0 Mon Sep 17 00:00:00 2001 From: John Guo Date: Mon, 18 Apr 2022 20:57:41 +0800 Subject: [PATCH] fix issue #1750 --- util/gconv/gconv.go | 8 ++++++-- util/gconv/gconv_z_unit_slice_test.go | 4 ++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/util/gconv/gconv.go b/util/gconv/gconv.go index 848ce1bfa..b2de0d507 100644 --- a/util/gconv/gconv.go +++ b/util/gconv/gconv.go @@ -264,14 +264,18 @@ func checkJsonAndUnmarshalUseNumber(any interface{}, target interface{}) bool { switch r := any.(type) { case []byte: if json.Valid(r) { - _ = json.UnmarshalUseNumber(r, &target) + if err := json.UnmarshalUseNumber(r, &target); err != nil { + return false + } return true } case string: anyAsBytes := []byte(r) if json.Valid(anyAsBytes) { - _ = json.UnmarshalUseNumber(anyAsBytes, &target) + if err := json.UnmarshalUseNumber(anyAsBytes, &target); err != nil { + return false + } return true } } diff --git a/util/gconv/gconv_z_unit_slice_test.go b/util/gconv/gconv_z_unit_slice_test.go index 019bf4aec..7ce358a4f 100644 --- a/util/gconv/gconv_z_unit_slice_test.go +++ b/util/gconv/gconv_z_unit_slice_test.go @@ -103,6 +103,10 @@ func Test_Strings(t *testing.T) { } t.AssertEQ(gconv.Strings(array), []string{"1", "2", "3"}) }) + // https://github.com/gogf/gf/issues/1750 + gtest.C(t, func(t *gtest.T) { + t.AssertEQ(gconv.Strings("123"), []string{"123"}) + }) } func Test_Slice_Interfaces(t *testing.T) {