From f22b98456f73568ced160de6dc16f68b38397640 Mon Sep 17 00:00:00 2001 From: John Date: Fri, 3 Apr 2020 15:18:35 +0800 Subject: [PATCH] add default value of MaxActive configuration for package gredis --- database/gredis/gredis.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/database/gredis/gredis.go b/database/gredis/gredis.go index f6828d6d2..585713f0d 100644 --- a/database/gredis/gredis.go +++ b/database/gredis/gredis.go @@ -57,6 +57,7 @@ const ( gDEFAULT_POOL_IDLE_TIMEOUT = 10 * time.Second gDEFAULT_POOL_CONN_TIMEOUT = 10 * time.Second gDEFAULT_POOL_MAX_IDLE = 10 + gDEFAULT_POOL_MAX_ACTIVE = 100 gDEFAULT_POOL_MAX_LIFE_TIME = 30 * time.Second ) @@ -74,6 +75,10 @@ func New(config Config) *Redis { if config.MaxIdle == 0 { config.MaxIdle = gDEFAULT_POOL_MAX_IDLE } + // This value SHOULD NOT exceed the connection limit of redis server. + if config.MaxActive == 0 { + config.MaxActive = gDEFAULT_POOL_MAX_ACTIVE + } if config.IdleTimeout == 0 { config.IdleTimeout = gDEFAULT_POOL_IDLE_TIMEOUT } @@ -126,6 +131,9 @@ func New(config Config) *Redis { // NewFromStr creates a redis client object with given configuration string. // Redis client maintains a connection pool automatically. +// The parameter like: +// 127.0.0.1:6379,0 +// 127.0.0.1:6379,0,password func NewFromStr(str string) (*Redis, error) { config, err := ConfigFromStr(str) if err != nil {