Files
gf/os/gcfg/gcfg.go
Jack Ling 1ab0b18115 feat(os/gcfg): add GetEffective method with standard config priority (#4673)
## Summary
- Add `GetEffective` and `MustGetEffective` methods following 12-Factor
App config priority
- Priority: Command line > Environment variables > Config file > Default
value
- Add clarifying notes to existing `GetWithEnv`/`GetWithCmd` methods
- Add comprehensive unit tests

## Test plan
- [x] All gcfg unit tests pass (44 tests)
- [x] New `Test_GetEffective` covers 6 scenarios:
  - Config file only
  - Env overrides config
  - Cmd overrides env
  - Default value fallback
  - Empty string override (industry standard)
  - Key only in env

Closes #4650

---------

Co-authored-by: John Guo <claymore1986@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-02-26 09:45:56 +08:00

262 lines
8.3 KiB
Go

// Copyright GoFrame Author(https://goframe.org). All Rights Reserved.
//
// This Source Code Form is subject to the terms of the MIT License.
// If a copy of the MIT was not distributed with this file,
// You can obtain one at https://github.com/gogf/gf.
// Package gcfg provides reading, caching and managing for configuration.
package gcfg
import (
"context"
"github.com/gogf/gf/v2/container/gvar"
"github.com/gogf/gf/v2/errors/gcode"
"github.com/gogf/gf/v2/errors/gerror"
"github.com/gogf/gf/v2/internal/command"
"github.com/gogf/gf/v2/internal/intlog"
"github.com/gogf/gf/v2/internal/utils"
"github.com/gogf/gf/v2/os/genv"
)
// Config is the configuration management object.
type Config struct {
adapter Adapter
}
const (
// DefaultInstanceName is the default instance name for instance usage.
DefaultInstanceName = "config"
// DefaultConfigFileName is the default configuration file name.
DefaultConfigFileName = "config"
)
// New creates and returns a Config object with default adapter of AdapterFile.
func New() (*Config, error) {
adapterFile, err := NewAdapterFile()
if err != nil {
return nil, err
}
return &Config{
adapter: adapterFile,
}, nil
}
// NewWithAdapter creates and returns a Config object with given adapter.
func NewWithAdapter(adapter Adapter) *Config {
return &Config{
adapter: adapter,
}
}
// Instance returns an instance of Config with default settings.
// The parameter `name` is the name for the instance. But very note that, if the file "name.toml"
// exists in the configuration directory, it then sets it as the default configuration file. The
// toml file type is the default configuration file type.
func Instance(name ...string) *Config {
var instanceName = DefaultInstanceName
if len(name) > 0 && name[0] != "" {
instanceName = name[0]
}
return localInstances.GetOrSetFuncLock(instanceName, func() *Config {
adapterFile, err := NewAdapterFile()
if err != nil {
intlog.Errorf(context.Background(), `%+v`, err)
return nil
}
if instanceName != DefaultInstanceName {
adapterFile.SetFileName(instanceName)
}
return NewWithAdapter(adapterFile)
})
}
// SetAdapter sets the adapter of the current Config object.
func (c *Config) SetAdapter(adapter Adapter) {
c.adapter = adapter
}
// GetAdapter returns the adapter of the current Config object.
func (c *Config) GetAdapter() Adapter {
return c.adapter
}
// Available checks and returns the configuration service is available.
// The optional parameter `pattern` specifies certain configuration resource.
//
// It returns true if configuration file is present in default AdapterFile, or else false.
// Note that this function does not return error as it just does simply check for backend configuration service.
func (c *Config) Available(ctx context.Context, resource ...string) (ok bool) {
return c.adapter.Available(ctx, resource...)
}
// Get retrieves and returns value by specified `pattern`.
// It returns all values of current Json object if `pattern` is given empty or string ".".
// It returns nil if no value found by `pattern`.
//
// It returns a default value specified by `def` if value for `pattern` is not found.
func (c *Config) Get(ctx context.Context, pattern string, def ...any) (*gvar.Var, error) {
var (
err error
value any
)
value, err = c.adapter.Get(ctx, pattern)
if err != nil {
return nil, err
}
if value == nil {
if len(def) > 0 {
return gvar.New(def[0]), nil
}
return nil, nil
}
return gvar.New(value), nil
}
// GetWithEnv returns the configuration value specified by pattern `pattern`.
// If the configuration value does not exist, then it retrieves and returns the environment value specified by `key`.
// It returns the default value `def` if none of them exists.
//
// Fetching Rules: Environment arguments are in uppercase format, eg: GF_PACKAGE_VARIABLE.
//
// Note: This method uses the configuration (adapter) as the primary source, with environment
// variable as fallback only when the configuration value is not found. If you need standard
// priority where environment variables can override configuration values, use GetEffective instead.
func (c *Config) GetWithEnv(ctx context.Context, pattern string, def ...any) (*gvar.Var, error) {
value, err := c.Get(ctx, pattern)
if err != nil && gerror.Code(err) != gcode.CodeNotFound {
return nil, err
}
if value == nil {
if v := genv.Get(utils.FormatEnvKey(pattern)); v != nil {
return v, nil
}
if len(def) > 0 {
return gvar.New(def[0]), nil
}
return nil, nil
}
return value, nil
}
// GetWithCmd returns the configuration value specified by pattern `pattern`.
// If the configuration value does not exist, then it retrieves and returns the command line option specified by `key`.
// It returns the default value `def` if none of them exists.
//
// Fetching Rules: Command line arguments are in lowercase format, eg: gf.package.variable.
//
// Note: This method uses configuration file as the primary source, with command line argument
// as fallback only when config value is not found. If you need standard priority where
// command line arguments can override config file values, use GetEffective instead.
func (c *Config) GetWithCmd(ctx context.Context, pattern string, def ...any) (*gvar.Var, error) {
value, err := c.Get(ctx, pattern)
if err != nil && gerror.Code(err) != gcode.CodeNotFound {
return nil, err
}
if value == nil {
if v := command.GetOpt(utils.FormatCmdKey(pattern)); v != "" {
return gvar.New(v), nil
}
if len(def) > 0 {
return gvar.New(def[0]), nil
}
return nil, nil
}
return value, nil
}
// GetEffective returns the configuration value with standard priority (highest to lowest):
//
// Command line arguments > Environment variables > Configuration file > Default value
//
// This follows the 12-Factor App methodology where higher priority sources can override
// lower priority ones, allowing runtime configuration without modifying config files.
//
// Key format conversion:
// - Command line: lowercase with dots, eg: gf.package.variable (--gf.package.variable=value)
// - Environment: uppercase with underscores, eg: GF_PACKAGE_VARIABLE
//
// Unlike GetWithEnv/GetWithCmd which use config file as primary source, this method
// treats command line and environment variables as overrides, which is the standard
// behavior in frameworks like Spring Boot and Viper.
func (c *Config) GetEffective(ctx context.Context, pattern string, def ...any) (*gvar.Var, error) {
// 1. Command line arguments (highest priority)
cmdKey := utils.FormatCmdKey(pattern)
if command.ContainsOpt(cmdKey) {
return gvar.New(command.GetOpt(cmdKey)), nil
}
// 2. Environment variables
if v := genv.Get(utils.FormatEnvKey(pattern)); v != nil {
return v, nil
}
// 3. Configuration file
value, err := c.Get(ctx, pattern)
if err != nil && gerror.Code(err) != gcode.CodeNotFound {
return nil, err
}
if value != nil {
return value, nil
}
// 4. Default value
if len(def) > 0 {
return gvar.New(def[0]), nil
}
return nil, nil
}
// Data retrieves and returns all configuration data as map type.
func (c *Config) Data(ctx context.Context) (data map[string]any, err error) {
return c.adapter.Data(ctx)
}
// MustGet acts as function Get, but it panics if error occurs.
func (c *Config) MustGet(ctx context.Context, pattern string, def ...any) *gvar.Var {
v, err := c.Get(ctx, pattern, def...)
if err != nil {
panic(err)
}
if v == nil {
return nil
}
return v
}
// MustGetWithEnv acts as function GetWithEnv, but it panics if error occurs.
func (c *Config) MustGetWithEnv(ctx context.Context, pattern string, def ...any) *gvar.Var {
v, err := c.GetWithEnv(ctx, pattern, def...)
if err != nil {
panic(err)
}
return v
}
// MustGetWithCmd acts as function GetWithCmd, but it panics if error occurs.
func (c *Config) MustGetWithCmd(ctx context.Context, pattern string, def ...any) *gvar.Var {
v, err := c.GetWithCmd(ctx, pattern, def...)
if err != nil {
panic(err)
}
return v
}
// MustGetEffective acts as function GetEffective, but it panics if error occurs.
func (c *Config) MustGetEffective(ctx context.Context, pattern string, def ...any) *gvar.Var {
v, err := c.GetEffective(ctx, pattern, def...)
if err != nil {
panic(err)
}
return v
}
// MustData acts as function Data, but it panics if error occurs.
func (c *Config) MustData(ctx context.Context) map[string]any {
v, err := c.Data(ctx)
if err != nil {
panic(err)
}
return v
}