mirror of
https://gitee.com/johng/gf
synced 2026-06-06 02:25:47 +08:00
This pull request introduces significant improvements to the handling of the `Replace` and `Save` operations for multiple database drivers, especially for MSSQL and PostgreSQL. The changes ensure that these operations now auto-detect primary keys when conflict columns are not explicitly provided, improving usability and aligning behavior across drivers. Additionally, the pull request updates related tests to reflect these enhancements and includes some minor documentation and code cleanup. **Key changes:** ### Enhanced Replace/Save Logic for Database Drivers * **MSSQL Driver:** - `Replace` and `Save` operations now auto-detect primary keys if `OnConflict` is not specified, using the `MERGE` statement for upsert functionality. If no primary key is found in the data, a detailed error is returned. [[1]](diffhunk://#diff-87815aa559a927e2de09bd05148f9841dfc06a1b5f3ecc5e3d5fcb80323a87f8L23-R61) [[2]](diffhunk://#diff-87815aa559a927e2de09bd05148f9841dfc06a1b5f3ecc5e3d5fcb80323a87f8L43-L59) - Updated tests to verify that `Replace` correctly updates or inserts records, and that missing conflict columns are properly handled. [[1]](diffhunk://#diff-bdbde9d7d6ee14c795343767b414740c4396f4dd3e97788b1f9d4e615405a42dL141-R151) [[2]](diffhunk://#diff-26338e93e473300b1313936eb0f6826546473793442f24715fa294b595f7a805L2661-R2707) * **PostgreSQL Driver:** - Similar to MSSQL, `Replace` and `Save` now auto-detect primary keys for conflict resolution if `OnConflict` is not set, and treat `Replace` as a `Save` operation. - Adjusted tests to ensure `Save` and `Replace` work as expected, including verifying data replacement and insertion. [[1]](diffhunk://#diff-c22703c37ebb6836c332f7cd2ada570577ba4564fe39886db02f7c2d0e7a2048L93-R93) [[2]](diffhunk://#diff-c22703c37ebb6836c332f7cd2ada570577ba4564fe39886db02f7c2d0e7a2048R102) [[3]](diffhunk://#diff-c22703c37ebb6836c332f7cd2ada570577ba4564fe39886db02f7c2d0e7a2048L110-R130) * **DM Driver:** - Improved conflict detection: now checks that at least one primary key exists in the provided data when `OnConflict` is not specified, and provides clearer error messages. - Refactored to use the core method for primary key detection and removed redundant code. ### Minor Improvements and Documentation * Added clarifying comments to `DoInsert` methods for ClickHouse, DM, MSSQL, Oracle, and PostgreSQL drivers, specifying that the input list must have at least one validated record. [[1]](diffhunk://#diff-f2e003895041ed3c52b91bb8c270696adc3528d77c39d2f7137af3396267444cR19) [[2]](diffhunk://#diff-f51b30e3f0b0f1284b905385a89992efd0de2fe9ff8c5a4062344dfab17d428eR23) [[3]](diffhunk://#diff-87815aa559a927e2de09bd05148f9841dfc06a1b5f3ecc5e3d5fcb80323a87f8L23-R61) [[4]](diffhunk://#diff-f61dac3fcfd5df4a3936cd8743499c8c0fc45f4f5d0f5398ed84a0cb1603202cR24) [[5]](diffhunk://#diff-c1dfed79aaa3a432057d2bd74d270e4b4094ebcf72984f1161d4972bea009410R16-R72) * Minor code and comment cleanups, including improved formatting and error handling. [[1]](diffhunk://#diff-f61dac3fcfd5df4a3936cd8743499c8c0fc45f4f5d0f5398ed84a0cb1603202cR37) [[2]](diffhunk://#diff-f61dac3fcfd5df4a3936cd8743499c8c0fc45f4f5d0f5398ed84a0cb1603202cL96-R98) [[3]](diffhunk://#diff-f61dac3fcfd5df4a3936cd8743499c8c0fc45f4f5d0f5398ed84a0cb1603202cL106-L116) [[4]](diffhunk://#diff-a17b44c76aaac53d1f164a2bb9440a5531659f4355e7ccfabdadff8dc8633c09L170-R171) [[5]](diffhunk://#diff-56189fa9ae1df51716b50d34d7fe56bfe67a330e8ac2c6b0de7b958db6817ed5R83-R98) ### Workflow and Documentation Updates * Updated example Docker commands in the CI workflow for consistency and clarity. [[1]](diffhunk://#diff-a1a3cb9bdeb5541d148091d973cf266aa3b317e6415a86630e816cbe27cf8b9cL57-R57) [[2]](diffhunk://#diff-a1a3cb9bdeb5541d148091d973cf266aa3b317e6415a86630e816cbe27cf8b9cL78-R78) [[3]](diffhunk://#diff-a1a3cb9bdeb5541d148091d973cf266aa3b317e6415a86630e816cbe27cf8b9cL92-R92) [[4]](diffhunk://#diff-a1a3cb9bdeb5541d148091d973cf266aa3b317e6415a86630e816cbe27cf8b9cL106-R106) [[5]](diffhunk://#diff-a1a3cb9bdeb5541d148091d973cf266aa3b317e6415a86630e816cbe27cf8b9cL153-R153) [[6]](diffhunk://#diff-a1a3cb9bdeb5541d148091d973cf266aa3b317e6415a86630e816cbe27cf8b9cL164-R164) * Removed outdated note about `Replace` support from the SQLite driver documentation. These changes improve the consistency, reliability, and developer experience when performing upsert operations across different database backends. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Lance Add <1196661499@qq.com>
121 lines
3.2 KiB
Go
121 lines
3.2 KiB
Go
// Copyright GoFrame Author(https://goframe.org). All Rights Reserved.
|
|
//
|
|
// This Source Code Form is subject to the terms of the MIT License.
|
|
// If a copy of the MIT was not distributed with this file,
|
|
// You can obtain one at https://github.com/gogf/gf.
|
|
|
|
package oracle
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/gogf/gf/v2/database/gdb"
|
|
"github.com/gogf/gf/v2/errors/gcode"
|
|
"github.com/gogf/gf/v2/errors/gerror"
|
|
)
|
|
|
|
const (
|
|
returningClause = " RETURNING %s INTO ?"
|
|
)
|
|
|
|
// DoExec commits the sql string and its arguments to underlying driver
|
|
// through given link object and returns the execution result.
|
|
// It handles INSERT statements specially to support LastInsertId.
|
|
func (d *Driver) DoExec(
|
|
ctx context.Context, link gdb.Link, sql string, args ...interface{},
|
|
) (result sql.Result, err error) {
|
|
var (
|
|
isUseCoreDoExec = true
|
|
primaryKey string
|
|
pkField gdb.TableField
|
|
)
|
|
|
|
// Transaction checks.
|
|
if link == nil {
|
|
if tx := gdb.TXFromCtx(ctx, d.GetGroup()); tx != nil {
|
|
link = tx
|
|
} else if link, err = d.MasterLink(); err != nil {
|
|
return nil, err
|
|
}
|
|
} else if !link.IsTransaction() {
|
|
if tx := gdb.TXFromCtx(ctx, d.GetGroup()); tx != nil {
|
|
link = tx
|
|
}
|
|
}
|
|
|
|
// Check if it is an insert operation with primary key from context.
|
|
if value := ctx.Value(internalPrimaryKeyInCtx); value != nil {
|
|
if field, ok := value.(gdb.TableField); ok {
|
|
pkField = field
|
|
isUseCoreDoExec = false
|
|
}
|
|
}
|
|
|
|
// Check if it is an INSERT statement with primary key.
|
|
if !isUseCoreDoExec && pkField.Name != "" && strings.Contains(strings.ToUpper(sql), "INSERT INTO") {
|
|
primaryKey = pkField.Name
|
|
// Oracle supports RETURNING clause to get the last inserted id
|
|
sql += fmt.Sprintf(returningClause, d.QuoteWord(primaryKey))
|
|
} else {
|
|
// Use default DoExec for non-INSERT or no primary key scenarios
|
|
return d.Core.DoExec(ctx, link, sql, args...)
|
|
}
|
|
|
|
// Only the insert operation with primary key can execute the following code
|
|
|
|
// SQL filtering.
|
|
sql, args = d.FormatSqlBeforeExecuting(sql, args)
|
|
sql, args, err = d.DoFilter(ctx, link, sql, args)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Prepare output variable for RETURNING clause
|
|
var lastInsertId int64
|
|
// Append the output parameter for the RETURNING clause
|
|
args = append(args, &lastInsertId)
|
|
|
|
// Link execution.
|
|
_, err = d.DoCommit(ctx, gdb.DoCommitInput{
|
|
Link: link,
|
|
Sql: sql,
|
|
Args: args,
|
|
Stmt: nil,
|
|
Type: gdb.SqlTypeExecContext,
|
|
IsTransaction: link.IsTransaction(),
|
|
})
|
|
|
|
if err != nil {
|
|
return &Result{
|
|
lastInsertId: 0,
|
|
rowsAffected: 0,
|
|
lastInsertIdError: err,
|
|
}, err
|
|
}
|
|
|
|
// Get rows affected from the result
|
|
// For single insert with RETURNING clause, affected is always 1
|
|
var affected int64 = 1
|
|
|
|
// Check if the primary key field type supports LastInsertId
|
|
if !strings.Contains(strings.ToLower(pkField.Type), "int") {
|
|
return &Result{
|
|
lastInsertId: 0,
|
|
rowsAffected: affected,
|
|
lastInsertIdError: gerror.NewCodef(
|
|
gcode.CodeNotSupported,
|
|
"LastInsertId is not supported by primary key type: %s",
|
|
pkField.Type,
|
|
),
|
|
}, nil
|
|
}
|
|
|
|
return &Result{
|
|
lastInsertId: lastInsertId,
|
|
rowsAffected: affected,
|
|
}, nil
|
|
}
|