bingyi/vscode-extension-samples
1
0
Fork 0
mirror of https://github.com/microsoft/vscode-extension-samples.git synced 2026-06-13 07:10:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use standard tslint rules for source-control example

Browse Source
This commit is contained in:
Matt Bierner
2019-05-10 14:45:55 -07:00
parent 5553fee13b
commit 12a3528bae
5 changed files with 41 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
source-control-sample/src/fiddleRepository.ts
View File

@ -15,9 +15,9 @@ export interface FiddleData {
}
export function areIdentical(first: FiddleData, second: FiddleData): boolean {
return first.html == second.html
&& first.css == second.css
&& first.js == second.js;
return first.html === second.html
&& first.css === second.css
&& first.js === second.js;
}
export const JSFIDDLE_SCHEME = 'jsfiddle';
@ -69,10 +69,10 @@ export async function downloadFiddle(slug: string, version: number | undefined):
if (slug === "demo") {
// use mock fiddle
if (demoVersionOffset === undefined && version === undefined) version = 0;
if (demoVersionOffset === undefined) demoVersionOffset = version;
if (demoVersionOffset === undefined && version === undefined) { version = 0; }
if (demoVersionOffset === undefined) { demoVersionOffset = version; }
let maxDemoVersion = DEMO.length - 1 + demoVersionOffset;
if (version === undefined) version = maxDemoVersion;
if (version === undefined) { version = maxDemoVersion; }
if (version >= 0 && version <= maxDemoVersion) {
// mock all versions committed in previous sessions by the first version
@ -81,7 +81,7 @@ export async function downloadFiddle(slug: string, version: number | undefined):
return new Fiddle(slug, version, fiddleData);
}
else {
throw "Invalid demo fiddle version.";
throw new Error("Invalid demo fiddle version.");
}
}
@ -90,7 +90,7 @@ export async function downloadFiddle(slug: string, version: number | undefined):
return new Promise<Fiddle>((resolve, reject) => {
JSFiddle.getFiddle(id, (err: any, fiddleData: any) => {
// handle error
if (err) reject(err);
if (err) { reject(err); }
let fiddle = new Fiddle(slug, version, fiddleData);