From 9da84f870b957e62c7028f2d34a685e233c61362 Mon Sep 17 00:00:00 2001 From: KamasamaK Date: Thu, 14 Apr 2022 06:04:01 -0400 Subject: [PATCH 1/2] Remove unused enableProposedApi --- comment-sample/package.json | 3 +-- extension-terminal-sample/README.md | 7 +------ extension-terminal-sample/package.json | 5 ++--- extension-terminal-sample/src/extension.ts | 2 +- 4 files changed, 5 insertions(+), 12 deletions(-) diff --git a/comment-sample/package.json b/comment-sample/package.json index 856e511b..12d04266 100644 --- a/comment-sample/package.json +++ b/comment-sample/package.json @@ -13,7 +13,6 @@ "engines": { "vscode": "^1.35.0" }, - "enableProposedApi": true, "categories": [ "Other" ], @@ -161,7 +160,7 @@ }, "devDependencies": { "@types/node": "^12.12.0", - "@types/vscode": "^1.35.0", + "@types/vscode": "~1.35.0", "@typescript-eslint/eslint-plugin": "^5.19.0", "@typescript-eslint/parser": "^5.19.0", "eslint": "^8.13.0", diff --git a/extension-terminal-sample/README.md b/extension-terminal-sample/README.md index 97beece7..8001d140 100644 --- a/extension-terminal-sample/README.md +++ b/extension-terminal-sample/README.md @@ -1,6 +1,6 @@ # extension-terminal-sample -This extension shows how to leverage the extension terminal API proposed in v1.37 that enables an extension to handle a terminal's input and emit output. +This extension shows how to leverage the extension terminal API stabilized in v1.39 that enables an extension to handle a terminal's input and emit output. ## VS Code API @@ -8,11 +8,6 @@ This extension shows how to leverage the extension terminal API proposed in v1.3 - [window.createTerminal](https://code.visualstudio.com/api/references/vscode-api#window.createTerminal) -### Proposed API - -- `window.Pseudoterminal` -- `window.ExtensionTerminalOptions` - ### Contribution Points - [`contributes.commands`](https://code.visualstudio.com/api/references/contribution-points#contributes.commands) diff --git a/extension-terminal-sample/package.json b/extension-terminal-sample/package.json index a1f19269..85303a9e 100644 --- a/extension-terminal-sample/package.json +++ b/extension-terminal-sample/package.json @@ -11,9 +11,8 @@ "url": "https://github.com/Microsoft/vscode-extension-samples" }, "engines": { - "vscode": "^1.37.0" + "vscode": "^1.39.0" }, - "enableProposedApi": true, "categories": [ "Other" ], @@ -42,7 +41,7 @@ }, "devDependencies": { "@types/node": "^12.12.0", - "@types/vscode": "^1.33.0", + "@types/vscode": "~1.39.0", "@typescript-eslint/eslint-plugin": "^5.19.0", "@typescript-eslint/parser": "^5.19.0", "eslint": "^8.13.0", diff --git a/extension-terminal-sample/src/extension.ts b/extension-terminal-sample/src/extension.ts index 1f4991f8..028199c1 100644 --- a/extension-terminal-sample/src/extension.ts +++ b/extension-terminal-sample/src/extension.ts @@ -31,7 +31,7 @@ export function activate(context: vscode.ExtensionContext) { writeEmitter.fire(data); } }; - const terminal = (vscode.window).createTerminal({ name: `My Extension REPL`, pty }); + const terminal = vscode.window.createTerminal({ name: `My Extension REPL`, pty }); terminal.show(); })); From f955fd4ceeda5239037bceaff68b5d139181cd1e Mon Sep 17 00:00:00 2001 From: KamasamaK Date: Thu, 14 Apr 2022 06:06:06 -0400 Subject: [PATCH 2/2] Update VS Code engine --- comment-sample/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/comment-sample/package.json b/comment-sample/package.json index 12d04266..468ef9eb 100644 --- a/comment-sample/package.json +++ b/comment-sample/package.json @@ -11,7 +11,7 @@ "url": "https://github.com/Microsoft/vscode-extension-samples" }, "engines": { - "vscode": "^1.35.0" + "vscode": "^1.65.0" }, "categories": [ "Other" @@ -160,7 +160,7 @@ }, "devDependencies": { "@types/node": "^12.12.0", - "@types/vscode": "~1.35.0", + "@types/vscode": "~1.65.0", "@typescript-eslint/eslint-plugin": "^5.19.0", "@typescript-eslint/parser": "^5.19.0", "eslint": "^8.13.0",