From c372eee4a1b4d5f71bd9221f00920374ba131a14 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20M=C3=AD=C5=A1ek?= Date: Sat, 26 Feb 2022 01:28:11 +0100 Subject: [PATCH] do not encode the `?target=web` query parameter fixes https://github.com/microsoft/vscode-extension-samples/issues/560 The path to `browserServerMain.js` has target=web query parameter when running on web. `Uri.toString()`, by default, encodes the `=` character so the resource is not loaded correctly from the unpkg service when published to marketplace --- lsp-web-extension-sample/client/src/browserClientMain.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lsp-web-extension-sample/client/src/browserClientMain.ts b/lsp-web-extension-sample/client/src/browserClientMain.ts index 4c29a644..1cb5f669 100644 --- a/lsp-web-extension-sample/client/src/browserClientMain.ts +++ b/lsp-web-extension-sample/client/src/browserClientMain.ts @@ -39,7 +39,7 @@ export function activate(context: ExtensionContext) { function createWorkerLanguageClient(context: ExtensionContext, clientOptions: LanguageClientOptions) { // Create a worker. The worker main file implements the language server. const serverMain = Uri.joinPath(context.extensionUri, 'server/dist/browserServerMain.js'); - const worker = new Worker(serverMain.toString()); + const worker = new Worker(serverMain.toString(true)); // create the language server client to communicate with the server running in the worker return new LanguageClient('lsp-web-extension-sample', 'LSP Web Extension Sample', clientOptions, worker);