From b2e0685b28186cc7ec2ed9273178a6bfadd994da Mon Sep 17 00:00:00 2001 From: Dirk Baeumer Date: Mon, 4 Sep 2017 21:47:00 +0200 Subject: [PATCH] Stricter error checking --- lsp-sample/client/src/extension.ts | 4 ++-- lsp-sample/client/tsconfig.json | 4 ++++ lsp-sample/server/src/server.ts | 12 +++++------- lsp-sample/server/tsconfig.json | 4 ++++ 4 files changed, 15 insertions(+), 9 deletions(-) diff --git a/lsp-sample/client/src/extension.ts b/lsp-sample/client/src/extension.ts index 72df9363..08e123b7 100644 --- a/lsp-sample/client/src/extension.ts +++ b/lsp-sample/client/src/extension.ts @@ -6,8 +6,8 @@ import * as path from 'path'; -import { workspace, Disposable, ExtensionContext } from 'vscode'; -import { LanguageClient, LanguageClientOptions, SettingMonitor, ServerOptions, TransportKind } from 'vscode-languageclient'; +import { workspace, ExtensionContext } from 'vscode'; +import { LanguageClient, LanguageClientOptions, ServerOptions, TransportKind } from 'vscode-languageclient'; export function activate(context: ExtensionContext) { diff --git a/lsp-sample/client/tsconfig.json b/lsp-sample/client/tsconfig.json index c8b02609..b485ee7e 100644 --- a/lsp-sample/client/tsconfig.json +++ b/lsp-sample/client/tsconfig.json @@ -1,5 +1,9 @@ { "compilerOptions": { + "noUnusedLocals": true, + "noUnusedParameters": true, + "noImplicitAny": true, + "noImplicitReturns": true, "target": "es6", "module": "commonjs", "moduleResolution": "node", diff --git a/lsp-sample/server/src/server.ts b/lsp-sample/server/src/server.ts index 84620dca..5e017514 100644 --- a/lsp-sample/server/src/server.ts +++ b/lsp-sample/server/src/server.ts @@ -5,11 +5,9 @@ 'use strict'; import { - IPCMessageReader, IPCMessageWriter, - createConnection, IConnection, TextDocumentSyncKind, - TextDocuments, TextDocument, Diagnostic, DiagnosticSeverity, - InitializeParams, InitializeResult, TextDocumentPositionParams, - CompletionItem, CompletionItemKind + IPCMessageReader, IPCMessageWriter, createConnection, IConnection, TextDocuments, TextDocument, + Diagnostic, DiagnosticSeverity, InitializeResult, TextDocumentPositionParams, CompletionItem, + CompletionItemKind } from 'vscode-languageserver'; // Create a connection for the server. The connection uses Node's IPC as a transport @@ -91,14 +89,14 @@ function validateTextDocument(textDocument: TextDocument): void { connection.sendDiagnostics({ uri: textDocument.uri, diagnostics }); } -connection.onDidChangeWatchedFiles((change) => { +connection.onDidChangeWatchedFiles((_change) => { // Monitored files have change in VSCode connection.console.log('We recevied an file change event'); }); // This handler provides the initial list of the completion items. -connection.onCompletion((textDocumentPosition: TextDocumentPositionParams): CompletionItem[] => { +connection.onCompletion((_textDocumentPosition: TextDocumentPositionParams): CompletionItem[] => { // The pass parameter contains the position of the text document in // which code complete got requested. For the example we ignore this // info and always provide the same completion items. diff --git a/lsp-sample/server/tsconfig.json b/lsp-sample/server/tsconfig.json index 6032b82b..27c7eebc 100644 --- a/lsp-sample/server/tsconfig.json +++ b/lsp-sample/server/tsconfig.json @@ -1,5 +1,9 @@ { "compilerOptions": { + "noUnusedLocals": true, + "noUnusedParameters": true, + "noImplicitAny": true, + "noImplicitReturns": true, "target": "es6", "module": "commonjs", "moduleResolution": "node",