From ac518358a761711363b2cdf67159bbb4a465e482 Mon Sep 17 00:00:00 2001 From: Mavaddat Javid Date: Tue, 18 Jan 2022 12:32:27 -0800 Subject: [PATCH 1/4] Update the names of Debug panel and Launch --- lsp-sample/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lsp-sample/README.md b/lsp-sample/README.md index 17b850f1..9dfcde79 100644 --- a/lsp-sample/README.md +++ b/lsp-sample/README.md @@ -29,10 +29,10 @@ It also includes an End-to-End test. - Run `npm install` in this folder. This installs all necessary npm modules in both the client and server folder - Open VS Code on this folder. - Press Ctrl+Shift+B to compile the client and server. -- Switch to the Debug viewlet. -- Select `Launch Client` from the drop down. -- Run the launch config. -- If you want to debug the server as well use the launch configuration `Attach to Server` +- Switch to the Run and Debug panel in the Sidebar (Ctrl+Shift+D). +- Select `Launch Client` from the drop down (if it is not already). +- Press ▷ to run the launch config (F5). +- If you want to debug the server as well, use the launch configuration `Attach to Server` - In the [Extension Development Host] instance of VSCode, open a document in 'plain text' language mode. - Type `j` or `t` to see `Javascript` and `TypeScript` completion. - Enter text content such as `AAA aaa BBB`. The extension will emit diagnostics for all words in all-uppercase. From 4da6befe6293246f78b55dc45655ec7938a49a10 Mon Sep 17 00:00:00 2001 From: Mavaddat Javid Date: Tue, 18 Jan 2022 12:42:03 -0800 Subject: [PATCH 2/4] Describe default compile task The default compile task is in *watch mode*, which was confusing for me (newbie Typescript programmer). I thought I would provide an explanation of what this means. --- lsp-sample/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lsp-sample/README.md b/lsp-sample/README.md index 9dfcde79..b43565bc 100644 --- a/lsp-sample/README.md +++ b/lsp-sample/README.md @@ -28,7 +28,7 @@ It also includes an End-to-End test. - Run `npm install` in this folder. This installs all necessary npm modules in both the client and server folder - Open VS Code on this folder. -- Press Ctrl+Shift+B to compile the client and server. +- Press Ctrl+Shift+B to start compiling the client and server in [watch mode](https://code.visualstudio.com/docs/editor/tasks#:~:text=The%20first%20entry%20executes,the%20HelloWorld.js%20file.). - Switch to the Run and Debug panel in the Sidebar (Ctrl+Shift+D). - Select `Launch Client` from the drop down (if it is not already). - Press ▷ to run the launch config (F5). From 9b9dce26d18d6b3fe5c53b68f2e9fba5f2017c63 Mon Sep 17 00:00:00 2001 From: Mavaddat Javid Date: Tue, 18 Jan 2022 12:48:48 -0800 Subject: [PATCH 3/4] Explain Extension Development Host --- lsp-sample/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lsp-sample/README.md b/lsp-sample/README.md index b43565bc..122ffb0c 100644 --- a/lsp-sample/README.md +++ b/lsp-sample/README.md @@ -33,6 +33,6 @@ It also includes an End-to-End test. - Select `Launch Client` from the drop down (if it is not already). - Press ▷ to run the launch config (F5). - If you want to debug the server as well, use the launch configuration `Attach to Server` -- In the [Extension Development Host] instance of VSCode, open a document in 'plain text' language mode. +- In the [Extension Development Host](https://code.visualstudio.com/api/get-started/your-first-extension#:~:text=Then%2C%20inside%20the%20editor%2C%20press%20F5.%20This%20will%20compile%20and%20run%20the%20extension%20in%20a%20new%20Extension%20Development%20Host%20window.) instance of VSCode, open a document in 'plain text' language mode. - Type `j` or `t` to see `Javascript` and `TypeScript` completion. - Enter text content such as `AAA aaa BBB`. The extension will emit diagnostics for all words in all-uppercase. From 5e84aab1a6162a0978c47e888bef9cc2ecc47787 Mon Sep 17 00:00:00 2001 From: Mavaddat Javid Date: Wed, 19 Jan 2022 09:42:43 -0800 Subject: [PATCH 4/4] Update README.md Use 'View' instead of 'panel' for the Run and Debug section. --- lsp-sample/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lsp-sample/README.md b/lsp-sample/README.md index 122ffb0c..4c85fc76 100644 --- a/lsp-sample/README.md +++ b/lsp-sample/README.md @@ -29,7 +29,7 @@ It also includes an End-to-End test. - Run `npm install` in this folder. This installs all necessary npm modules in both the client and server folder - Open VS Code on this folder. - Press Ctrl+Shift+B to start compiling the client and server in [watch mode](https://code.visualstudio.com/docs/editor/tasks#:~:text=The%20first%20entry%20executes,the%20HelloWorld.js%20file.). -- Switch to the Run and Debug panel in the Sidebar (Ctrl+Shift+D). +- Switch to the Run and Debug View in the Sidebar (Ctrl+Shift+D). - Select `Launch Client` from the drop down (if it is not already). - Press ▷ to run the launch config (F5). - If you want to debug the server as well, use the launch configuration `Attach to Server`