bingyi/gf
1
0
Fork 0
mirror of https://gitee.com/johng/gf synced 2026-06-06 02:25:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

bugfix : when using otel, calling gclient *Raw methods may result in null pointer exceptions (#2697)

Browse Source
This commit is contained in:
muzifeng
2023-06-12 20:52:48 +08:00
committed by GitHub
parent 46f3196297
commit 15eaac35a8
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
net/gclient/gclient_tracing_tracer.go
View File

@ -73,9 +73,17 @@ func newClientTrace(ctx context.Context, span trace.Span, request *http.Request)
func (ct *clientTracer) getConn(host string) {}
func (ct *clientTracer) gotConn(info httptrace.GotConnInfo) {
remoteAddr := ""
if info.Conn.RemoteAddr() != nil {
remoteAddr = info.Conn.RemoteAddr().String()
}
localAddr := ""
if info.Conn.LocalAddr() != nil {
localAddr = info.Conn.LocalAddr().String()
}
ct.span.SetAttributes(
attribute.String(tracingAttrHttpAddressRemote, info.Conn.RemoteAddr().String()),
attribute.String(tracingAttrHttpAddressLocal, info.Conn.LocalAddr().String()),
attribute.String(tracingAttrHttpAddressRemote, remoteAddr),
attribute.String(tracingAttrHttpAddressLocal, localAddr),
)
}