Fixes #182: Fix npm audit issues reported in i18 samples

i18n-sample/.gitignore

@@ -2,3 +2,4 @@ out
 node_modules
 // These files will be generated from the i18n folder
 *nls.*.json
+*.vsix

i18n-sample/gulpfile.js

@@ -24,33 +24,27 @@ const outDest = 'out';
 // If all VS Code langaues are support you can use nls.coreLanguages
 const languages = [{ folderName: 'jpn', id: 'ja' }];
 
-gulp.task('default', function(callback) {
-	runSequence('build', callback);
-});
-
-gulp.task('compile', function(callback) {
-	runSequence('clean', 'internal-compile', callback);
-});
-
-gulp.task('build', function(callback) {
-	runSequence('clean', 'internal-nls-compile', 'add-i18n', callback);
-});
-
-gulp.task('publish', function(callback) {
-	runSequence('build', 'vsce:publish', callback);
-});
-
-gulp.task('package', function(callback) {
-	runSequence('build', 'vsce:package', callback);
-});
-
-gulp.task('clean', function() {
+const cleanTask = function() {
 	return del(['out/**', 'package.nls.*.json', 'i18n-sample*.vsix']);
-})
+}
 
-//---- internal
+const internalCompileTask = function() {
+	return doCompile(false);
+};
 
-function compile(buildNls) {
+const internalNlsCompileTask = function() {
+	return doCompile(true);
+};
+
+const addI18nTask = function() {
+	return gulp.src(['package.nls.json'])
+		.pipe(nls.createAdditionalLanguageFiles(languages, 'i18n'))
+		.pipe(gulp.dest('.'));
+};
+
+const buildTask = gulp.series(cleanTask, internalNlsCompileTask, addI18nTask);
+
+const doCompile = function (buildNls) {
 	var r = tsProject.src()
 		.pipe(sourcemaps.init())
 		.pipe(tsProject()).js
@@ -71,24 +65,22 @@ function compile(buildNls) {
 	return r.pipe(gulp.dest(outDest));
 }
 
-gulp.task('internal-compile', function() {
-	return compile(false);
-});
-
-gulp.task('internal-nls-compile', function() {
-	return compile(true);
-});
-
-gulp.task('add-i18n', function() {
-	return gulp.src(['package.nls.json'])
-		.pipe(nls.createAdditionalLanguageFiles(languages, 'i18n'))
-		.pipe(gulp.dest('.'));
-});
-
-gulp.task('vsce:publish', function() {
+const vscePublishTask = function() {
 	return vsce.publish();
-});
+};
 
-gulp.task('vsce:package', function() {
+const vscePackageTask = function() {
 	return vsce.createVSIX();
-});
+};
+
+gulp.task('default', buildTask);
+
+gulp.task('clean', cleanTask);
+
+gulp.task('compile', gulp.series(cleanTask, internalCompileTask));
+
+gulp.task('build', buildTask);
+
+gulp.task('publish', gulp.series(buildTask, vscePublishTask));
+
+gulp.task('package', gulp.series(buildTask, vscePackageTask));

i18n-sample/package.json

@@ -1,10 +1,11 @@
 {
 	"name": "i18n-sample",
+	"private": true,
 	"displayName": "i18n-sample",
 	"description": "Sample that shows how to localize an extension",
 	"repository": "https://github.com/Microsoft/vscode-extension-samples/i18n-sample",
 	"version": "0.1.0",
-	"publisher": "vscode-samples",
+	"publisher": "vscode-i18n-sample",
 	"engines": {
 		"vscode": "^1.32.0"
 	},
@@ -34,18 +35,19 @@
 		"clean": "gulp clean"
 	},
 	"devDependencies": {
-		"@types/node": "^6.0.40",
-		"@types/vscode": "^1.32.0",
-		"del": "^3.0.0",
-		"event-stream": "3.3.4",
-		"gulp": "^3.9.1",
-		"gulp-filter": "^5.0.1",
-		"gulp-typescript": "3.2.2",
-		"run-sequence": "^2.2.0",
+		"@types/node": "^12.0.1",
+		"del": "^4.1.1",
+		"event-stream": "^4.0.1",
+		"gulp": "^4.0.2",
+		"gulp-sourcemaps": "^2.6.5",
+		"gulp-filter": "^5.1.0",
+		"gulp-typescript": "^5.0.1",
+		"run-sequence": "^2.2.1",
 		"tslint": "^5.16.0",
 		"typescript": "^3.4.5",
 		"vsce": "^1.61.0",
-		"vscode-nls-dev": "^3.2.3"
+		"vscode": "^1.1.34",
+		"vscode-nls-dev": "^3.2.6"
 	},
 	"dependencies": {
 		"vscode-nls": "^3.2.5"