bingyi/vscode-extension-samples
1
0
Fork 0
mirror of https://github.com/microsoft/vscode-extension-samples.git synced 2026-04-27 16:55:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Handle a error case and name consistency

Browse Source
This commit is contained in:
Pine Wu
2016-11-17 10:12:45 -08:00
parent 0cec98c418
commit f3f2558f0c
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tree-explorer-sample/src/extension.ts
View File

@ -55,7 +55,7 @@ class DepNodeProvider implements TreeExplorerNodeProvider<DepNode> {
switch(node.kind) {
case 'root':
const packageJsonPath = path.join(this.workspaceRoot, 'package.json');
if (this.fileExists(packageJsonPath)) {
if (this.pathExists(packageJsonPath)) {
resolve(this.getDepsInPackageJson(packageJsonPath));
} else {
vscode.window.showInformationMessage('Workspace has no package.json');
@ -78,28 +78,32 @@ class DepNodeProvider implements TreeExplorerNodeProvider<DepNode> {
* Given the path to package.json, read all its dependencies and devDependencies.
*/
private getDepsInPackageJson(packageJsonPath: string): DepNode[] {
if (this.fileExists(packageJsonPath)) {
if (this.pathExists(packageJsonPath)) {
const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf-8'));
const toDep = (moduleName: string): DepNode => {
if (this.fileExists(path.join(this.workspaceRoot, 'node_modules', moduleName))) {
if (this.pathExists(path.join(this.workspaceRoot, 'node_modules', moduleName))) {
return new Node(moduleName);
} else {
return new Leaf(moduleName);
}
}
const deps = Object.keys(packageJson.dependencies).map(toDep);
const devDeps = Object.keys(packageJson.devDependencies).map(toDep);
const deps = packageJson.dependencies
? Object.keys(packageJson.dependencies).map(toDep)
: [];
const devDeps = packageJson.devDependencies
? Object.keys(packageJson.devDependencies).map(toDep)
: [];
return deps.concat(devDeps);
} else {
return [];
}
}
private fileExists(filePath: string): boolean {
private pathExists(p: string): boolean {
try {
fs.accessSync(filePath);
fs.accessSync(p);
} catch (err) {
return false;
}